Expand negative one check to all negatives #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Inequality editor for Chem/Nuclear, when a “-1” exists on screen and is using the binary minus symbol (but not when the minus is part of the number directly), items being dragged from the inequality menu will continue to be dragged even when placed.
The line causing this specific problem was
however this also highlights that the
isSolitaryNegativeOnefunction around it was outdated and causing inconsistent behaviour.All negative numbers are now treated equally in-grammar (they potentially weren't before?), so this change to broaden the function allows more answers to be processed correctly rather than leading to a syntax error.