Use lightweight validation responses for progress stats #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we loaded the full attempt JSON data from the database for every question attempt the user had made - but at no point do we need this data. We can avoid a great deal of deserialising if we instead load just the lightweight attempts, which we can do using existing queries (plus some plumbing). One bug was revealed; although the database query sorts the lightweight attempts identically to the full attempts, and the structure of the nested Maps is identical - the Lightweight code path used HashMaps but the full validation response code path used LinkedHashMaps. The former do not preserve insertion order, and so were removing this sorting. The existing uses of the data clearly did not need sorted attempts, but the My Progress stats page does. The cost of switching to the LinkedHashMap is small and only on creation; iterating over it as we do is much faster. This now preserves the (costly) sorting done in the DB.
|
In my testing, this was a little over 50% faster for users with large numbers of question attempts (because finding them in the database is still slow), but saves a (very) large amount of CPU work doing unnecessary deserialising! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
=======================================
Coverage 34.37% 34.37%
=======================================
Files 521 521
Lines 23478 23475 -3
Branches 2875 2875
=======================================
Hits 8070 8070
+ Misses 14596 14593 -3
Partials 812 812 ☔ View full report in Codecov by Sentry. |
axlewin
reviewed
Jan 16, 2025
src/main/java/uk/ac/cam/cl/dtg/segue/api/managers/QuestionManager.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Lewin <[email protected]>
axlewin
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we loaded the full attempt JSON data from the database for every question attempt the user had made - but at no point do we need this data. We can avoid a great deal of deserialising if we instead load just the lightweight attempts, which we can do using existing queries (plus some plumbing).
One bug was revealed; although the database query sorts the lightweight attempts identically to the full attempts, and the structure of the nested Maps is identical - the Lightweight code path used HashMaps but the full validation response code path used LinkedHashMaps. The former do not preserve insertion order, and so were removing this sorting. The existing uses of the data clearly did not need sorted attempts, but the My Progress stats page does. The cost of switching to the LinkedHashMap is small and only on creation; iterating over it as we do is much faster. This now preserves the (costly) sorting done in the DB.