Add external validator timeout #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a timeout specified here, the .send() call would block indefinitely. I believe 1 second is a safe enough limit; most validator requests take around 50-100ms (and trivial requests much less). However, we should keep an eye on this when deployed. This should prevent the validator from queuing too many requests and exhausting the Jetty threadpool.
For symbolic questions, the most common, explicitly log the timeout as an error by itself, to aid review of the timeout duration.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #670 +/- ##
==========================================
- Coverage 34.37% 34.37% -0.01%
==========================================
Files 521 521
Lines 23474 23477 +3
Branches 2875 2876 +1
==========================================
Hits 8070 8070
- Misses 14592 14595 +3
Partials 812 812 ☔ View full report in Codecov by Sentry. |
|
Tested this with adding sleep() to the symbolic validator locally and it works 👍 1 second seems like a reasonable cutoff point. This should stop the Jetty threads being the bottleneck, so I'll be curious to see how the validators themselves handle an influx of requests if/when we get that again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a timeout specified here, the .send() call would block indefinitely. I believe 1 second is a safe enough limit; most validator requests take around 50-100ms (and trivial requests much less).
However, we should keep an eye on this when deployed.
This should prevent the validator from queuing too many requests and exhausting the Jetty threadpool.
For symbolic questions, the most common, explicitly log the timeout as an error by itself, to aid review of the timeout duration.