Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor user creation logic for clarity #674

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

jsharkey13
Copy link
Member

Some functions had unhelpful names, and some operations were not done in the most sensible order. Separating out validation and storing should help when we come to split apart creating and updating.

Some functions had unhelpful names, and some operations were not done in
the most sensible order. Separating out validation and storing should
help when we come to split apart creating and updating.
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 34.85%. Comparing base (098a30c) to head (d3bb6a1).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
.../cl/dtg/segue/api/managers/UserAccountManager.java 37.50% 2 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   34.86%   34.85%   -0.01%     
==========================================
  Files         520      520              
  Lines       23327    23326       -1     
  Branches     2841     2841              
==========================================
- Hits         8132     8131       -1     
  Misses      14361    14361              
  Partials      834      834              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwtrew mwtrew merged commit 9a63776 into master Feb 11, 2025
5 checks passed
@mwtrew mwtrew deleted the refactor/user-creation branch February 11, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants