Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip z-index issues #1224

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Fix tooltip z-index issues #1224

merged 4 commits into from
Nov 14, 2024

Conversation

axlewin
Copy link
Contributor

@axlewin axlewin commented Nov 12, 2024

Fixes an issue where some tooltips fade in strangely due to elements behind them having a non-zero z-index.

Fixes an issue where some tooltips fade in strangely due to elements behind them having a non-zero z-index.
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.62%. Comparing base (d8fe857) to head (a082906).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1224   +/-   ##
=======================================
  Coverage   36.62%   36.62%           
=======================================
  Files         443      443           
  Lines       19490    19490           
  Branches     6371     6385   +14     
=======================================
  Hits         7138     7138           
  Misses      11706    11706           
  Partials      646      646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jacbn jacbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably apply these changes to all tooltips universally rather than each one individually; it can happen with the /events slot, for example, with the Help hoverable at the top in specific cases on mobile.

src/scss/common/tooltip.scss Outdated Show resolved Hide resolved
src/scss/common/tooltip.scss Outdated Show resolved Hide resolved
@jacbn jacbn merged commit a1cd9cd into master Nov 14, 2024
4 checks passed
@jacbn jacbn deleted the bug/tooltip-z-index branch November 14, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants