Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish Practice Tests #1229

Merged
merged 20 commits into from
Nov 22, 2024
Merged

Distinguish Practice Tests #1229

merged 20 commits into from
Nov 22, 2024

Conversation

jacbn
Copy link
Contributor

@jacbn jacbn commented Nov 19, 2024

  • Splits the listing of available practice tests into its own page, /practice_tests, accessible via the Learn nav;
  • Creates a new default table view for /tests (though the original card view is still accessible), which displays the title, assigner and relevant dates;
  • Splits assigned tests from practice tests into separate tabs at the topmost level of /tests; further filtering inside these categories (for started, not yet started, overdue and completed) can be achieved via the filters menu

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 29.81132% with 186 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@567b7ef). Learn more about missing BASE report.
Report is 63 commits behind head on master.

Files with missing lines Patch % Lines
src/app/components/pages/quizzes/MyQuizzes.tsx 12.90% 107 Missing and 1 partial ⚠️
...c/app/components/pages/quizzes/PracticeQuizzes.tsx 27.27% 29 Missing and 3 partials ⚠️
src/app/services/quiz.ts 33.33% 18 Missing and 2 partials ⚠️
...c/app/components/elements/CollapsibleContainer.tsx 23.07% 9 Missing and 1 partial ⚠️
src/app/services/gameboards.tsx 50.00% 4 Missing ⚠️
src/app/components/elements/tables/TableLinks.tsx 62.50% 3 Missing ⚠️
src/app/components/elements/CardGrid.tsx 0.00% 2 Missing ⚠️
...pp/components/elements/quiz/QuizProgressCommon.tsx 50.00% 2 Missing ⚠️
src/app/components/elements/svg/FilterCount.tsx 33.33% 2 Missing ⚠️
src/app/components/elements/CollapsibleList.tsx 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1229   +/-   ##
=========================================
  Coverage          ?   36.64%           
=========================================
  Files             ?      446           
  Lines             ?    19640           
  Branches          ?     6449           
=========================================
  Hits              ?     7198           
  Misses            ?    11798           
  Partials          ?      644           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

src/app/services/quiz.ts Outdated Show resolved Hide resolved
src/app/components/pages/quizzes/MyQuizzes.tsx Outdated Show resolved Hide resolved
src/app/components/pages/quizzes/PracticeQuizzes.tsx Outdated Show resolved Hide resolved
@axlewin axlewin merged commit 769fa7a into master Nov 22, 2024
4 checks passed
@axlewin axlewin deleted the feature/distinguish-practice-tests branch November 22, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants