Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline multiple choice questions #1232

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

jacbn
Copy link
Contributor

@jacbn jacbn commented Nov 21, 2024

Adds a new type of inline question, multiple choice, that creates a dropdown similar to (but slightly distinct from in structure) cloze questions in mobile view.

Also adds some type checking to InlineEntryZone such that adding further new inline questions is even easier, and collates all border / shadow colouring into the same place.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 26.47059% with 25 lines in your changes missing coverage. Please review.

Project coverage is 36.62%. Comparing base (834366f) to head (21eb979).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
...nts/elements/inputs/InlineMultiChoiceEntryZone.tsx 31.81% 15 Missing ⚠️
...onents/elements/markup/portals/InlineEntryZone.tsx 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
+ Coverage   36.60%   36.62%   +0.02%     
==========================================
  Files         443      444       +1     
  Lines       19509    19539      +30     
  Branches     5757     5764       +7     
==========================================
+ Hits         7141     7157      +16     
- Misses      12330    12344      +14     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@axlewin axlewin merged commit bedb5b9 into master Nov 22, 2024
4 checks passed
@axlewin axlewin deleted the feature/inline-multiple-choice branch November 22, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants