Configuration: Use toml instead of tomlkit
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It handles serializing `NoneType` values well, by just ignoring them. On the other hand, `tomlkit` and `tomli-w` croak on them.
amotl
force-pushed
the
amo/use-toml-package
branch
from
c3f14ea to
35ef7b2
Compare
Codecov ReportBase: 69.19% // Head: 69.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #27 +/- ##
==========================================
- Coverage 69.19% 69.13% -0.07%
==========================================
Files 53 52 -1
Lines 3084 3078 -6
==========================================
- Hits 2134 2128 -6
Misses 950 950
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
some research 1 into #25 revealed that only the
tomlpackage handles serializingNoneTypevalues well, by just ignoring them. On the other hand, bothtomlkitandtomli-wcroak on them.So, let's just switch to
tomlinstead.With kind regards,
Andreas.
P.S.: TOML does not know about any kinds of NULL values, that is why this issue is not unexpected. See also toml-lang/toml#921.
Footnotes
https://gist.github.com/amotl/4d8bc928d781a5d0fbc7f404396f8417 ↩