add snaphu2.0.4 support #313
Conversation
update to snaphu 2.0.3 and adding function for Tile support
Adding snaphu 2.0.3 functions for Tiles
change to snaphu 2.0.3 header files and adding Tile function to snaphumodules
replace with snaphu 2.0.3 source files
modify main snaphu function for python calls
Adding snaphu 2 support
There was a problem hiding this comment.
Thanks for the PR, @sharkbig. I suspect that a lot of SNAPHU users are accessing it via isce2, so this update is very valuable.
Please address my few comments/questions below when you get a chance.
In addition, I noticed that isce2 has the same issue with SNAPHU that we ran into with isce3, which is that the included CS2 source code is commercially licensed. Unless the isce2 authors have obtained some special permission, I don't believe we're allowed to redistribute that code. That's something we'll probably need to address promptly.
At the very least, we should reproduce the README file from the original SNAPHU codebase here, so that users will be aware that this code uses a different license than isce2's top-level Apache-2 license.
|
K I addressed all of the above comments and added in the "README" file from the original SNAPHU source. I also removed the "requirement" file, which seemed to be a development artifact and not related to the content of the PR. FYI, in the future you can make changes to your own PR in order to address reviewer comments by committing changes to your local clone of the repository and pushing them to the base branch of the PR. The PR will be automatically updated when you push. |
update snaphu source file to 2.0.4, and update function in contrib/Stack/unwrap.py to support unwrap in tiles