Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of Next-ViT #194

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Fix usage of Next-ViT #194

merged 1 commit into from
Jan 2, 2023

Conversation

rbirkl
Copy link
Contributor

@rbirkl rbirkl commented Jan 2, 2023

  • make Next-ViT optional by importing from Next-ViT repo only if Next-ViT model is used
  • use git submodule to include Next-ViT as external dependency (credit to hafriedlander)
  • replace shell script by installation instruction in readme

@rbirkl
Fix usage of Next-ViT
14560f2 
  - make Next-ViT optional by importing from Next-ViT repo only if Next-ViT model is used
  - use git submodule to include Next-ViT as external dependency (credit to hafriedlander)
  - replace shell script by installation instruction in readme
@thias15
Copy link
Contributor

thias15 commented Jan 2, 2023

Fixes #193

@thias15 thias15 linked an issue Jan 2, 2023 that may be closed by this pull request
IMPORTANT Your shell script breaks all apps using MiDaS #193
Closed
@thias15 thias15 merged commit ed20cc6 into master Jan 2, 2023
@thias15 thias15 deleted the Fix_Next_ViT branch January 2, 2023 13:18
@thias15 thias15 mentioned this pull request Jan 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thias15 thias15 thias15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IMPORTANT Your shell script breaks all apps using MiDaS
2 participants
@rbirkl @thias15