Compatibility with latest timm and torch #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this would fix thygate/stable-diffusion-webui-depthmap-script#319 @dwofk could you please merge this? |
|
@thias15 These are quite necessary changes. Could you please merge this? |
1 task
semjon00
added a commit
to thygate/stable-diffusion-webui-depthmap-script
that referenced
this pull request
Aug 28, 2023
Backports isl-org/MiDaS#234 Fixes #319 Fixes #323
semjon00
added a commit
to thygate/stable-diffusion-webui-depthmap-script
that referenced
this pull request
Aug 29, 2023
Backports isl-org/MiDaS#234 Fixes #319 Fixes #323
|
This change does not work with timm==0.6.12 installed on existing systems. |
|
@nagadomi I can change the PR to match lllyasviel's fix. I was under the assumption that this was the only issue preventing systems from updating to the latest timm. |
|
@AyaanShah2204 I think that would be great to support both timm==0.6.12 and timm==0.9.5 |
garywang
added a commit
to PolyCam/MiDaS
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torch Compatibility
We're working with the latest nightly version of torch. They seem to have added type asserts to interpolate (this commit).
This causes a runtime error because the size we pass in is of type
numpy.int32. A simple int-cast should fix this without any side effects.Timm compatibility
Blocks.drop_path()was deprecated and replaced withBlocks.drop_path1()andBlocks.drop_path2()in this commit. This has been causing a runtime error referenced in this issue.This has affected things downstream in ZoeDepth and Auto1111's controlnet extension.