Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3DVisualizer: Make size of selection indicator points adjustable, choose smarter default and make points removable #6725

Closed
3 tasks done
danrauch opened this issue Mar 27, 2024 · 0 comments · Fixed by #6733

Comments

@danrauch
Copy link
Contributor

danrauch commented Mar 27, 2024

Checklist

Proposed new feature or change

In the O3DVisualizer the current selection indicators points are massive if you load a point cloud which is scaled in e.g. mm:
selection_point_size

In the "old" VisualizerWithEditing it looks fine, but I cannot use it as it crashes when trying to run it in a non-blocking way (see #1605 or #4378):
old_visu

Smaller points are essential for robustly performing a manual N-point registration by point picking. So an UI element and API to adjust the point size would be appreciated. Also a smart default (like in the old visualizer) would be nice.

Further it would be helpful to be able to remove points after the fact, if one misclicked (again, like in the old visualizer).

References

No response

Additional information

No response

danrauch added a commit to danrauch/Open3D that referenced this issue Mar 29, 2024
…size calc

Correctly forward keymodifier to enable point removing and fix bounding
box calculation for picked point size selection.
ssheorey pushed a commit that referenced this issue Apr 17, 2024
) (#6733)

- Make points removable by correctly forwarding the key modifier to the already implemented function
- Fix bounding box calculation for picked point size selection (manual bbox extend calculation was wrong)
- Fix crash occurring when trying to make selection and non-pickable geometries where in scene
- Fix copy&paste error in help text for MACOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants