-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tensor FPFH #5429
Add Tensor FPFH #5429
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 15 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @reyanshsolis, @ssheorey, @yuecideng, and @yxlao)
.clang-format
line 5 at r2 (raw file):
ColumnLimit: 80 UseTab: Never # Standard: c++14
Is this change necessary? It affects formatting.
It was changed probably when I tried to fix the formatting issue in my PC. I will remove it anyway... @theNded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reyanshsolis would you please create a following PR on matching tensor FPFH using the tensor nns interface, if you have any bandwidth?
I also notice nns does not have pybind as of now if I understand correctly. Would this be an obstacle to implementation?
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @reyanshsolis, @ssheorey, @yuecideng, and @yxlao)
Update The parameters of nns search is sensitive to the time cost of comuputing fpfh with tensor API. We should avoid using large |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 15 files at r1, 1 of 6 files at r2, 1 of 4 files at r3, 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @reyanshsolis, @ssheorey, and @yuecideng)
This PR adds tensor
ComputeFPFHFeature
and use bunny mesh for unit test.This change is