Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ispc binary path on Windows, update civetweb to v1.16 #6577

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

AhmedZero
Copy link
Contributor

Type

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

solve ispc is not a full path to an existing compiler tool in Visual Studio 2022 and Windows 11

Copy link

update-docs bot commented Jan 7, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey self-requested a review February 9, 2024 23:47
@ssheorey
Copy link
Member

ssheorey commented Feb 9, 2024

Hi @AhmedZero, thanks for providing this bugfix! Can you talk about the civetweb upgrade? Is this related to the ispc issue?

Also the CI checks are not running, perhaps since the PR is not up to date with main. Can you update the PR with main ?

@AhmedZero
Copy link
Contributor Author

AhmedZero commented Feb 10, 2024

I faced that error when build
civetweb/civetweb#1024
and resolved in new version of civetweb
I update the PR with main

@ssheorey ssheorey changed the title ispc is not a full path to an existing compiler tool in Visual Studio 2022 and Windows 11 Update ispc binary path on Windows, update civetweb to v1.16 Apr 15, 2024
Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AhmedZero for the update.

Tested WebRTC (C++ and Python) visualization works with this PR after the civetweb update.

@ssheorey ssheorey merged commit 1562468 into isl-org:main Apr 16, 2024
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot configure CMake on Windows 11 with Ninja generator.
2 participants