-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched QHull ImGUI and GoogleTest to use FetchContent #6645
Conversation
…iles at configure time. This means that the open3d_build_3rdparty_library function doesn't need to mark source files as generated which was causing them to be removed when running the clean target.
…iles at configure time. This means that the open3d_build_3rdparty_library function doesn't need to mark source files as generated which was causing them to be removed when running the clean target.
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Hi @dbs4261 please check the CI errors. Removing GENERATED property causes CMake to fail with some file not found errors for 3rd party C++ sources. |
@ssheorey How can I run the CI pipeline locally to verify my fix? |
This PR doesn't depend on the platform. It should be sufficient if Open3D builds for you on your machine. Try building the library (make libopen3d), python package (make pip-package) and the tests (make tests) and running the tests on your machine. Make sure the build succeeds from an empty build folder. |
…es are provided at configure time instead of build time.
…urces. Sources are now downloaded at configure time.
Hmmm, Looks like the ubuntu-wheel build is failing because c-cache is out of space? Not sure what to do about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dbs4261 for simplifying the build process!
Fixing that in a separate PR. You can ignore that for this PR. |
Changed the CMake scripts for 3rdparty dependencies to not mark files in the Open3D git repo as generated. This is because the
clean
target would delete them and break the build.Motivation and Context
When running the clean target on some generators, source files not fetched by
ExternalProject
would be deleted. This would prevent rebuilding without using git to reset those files. See issue #6644 for details.Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Switched GoogleTest and QHull dependencies to use
FetchContent
instead ofExternalProject
. RemovedGENERATED
property from source files passed toopen3d_build_3rdparty_library
.