SamplePointsUniformly, Chamfer Distance, Hausdorff Distance and F-Score #7056
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
initializer_list -> vector TODO: Check F-Score values are correct
ssheorey
force-pushed
the
ss/sample-metrics
branch
from
b8651e9 to
312476a
Compare
Remove 0.5 from Chamfer Add reference and equations to docs. rename compute_distance -> compute_metrics Return Tensor instead of vector
ssheorey
changed the title
cpp/open3d/t/geometry/PointCloud.cpp
Outdated
| } | ||
|
|
||
| std::tie(indices12, distance12) = tree2.KnnSearch(points1, 1); | ||
| std::tie(indices21, distance21) = tree2.KnnSearch(points2, 1); |
There was a problem hiding this comment.
I think these are the squared distances
| namespace t { | ||
| namespace geometry { | ||
|
|
||
| core::Tensor ComputeMetricsCommon(core::Tensor distance12, |
There was a problem hiding this comment.
Need to define here that distancexx is the Euclidean distance
gcc compiler warning as error (doxygen math) fix
ssheorey
force-pushed
the
ss/sample-metrics
branch
from
8e19321 to
9f60d3d
Compare
| # (1, 3, 3, 1) vertices are shifted by (0, 0.1, 0.1*sqrt(2), 0.1*sqrt(3)) | ||
| # respectively | ||
| metric_params = MetricParameters( | ||
| fscore_radius=o3d.utility.FloatVector((0.01, 0.11, 0.15, 0.18))) |
There was a problem hiding this comment.
Do we need o3d.utility.FloatVector or can we pass a python list/tuple?
There was a problem hiding this comment.
I think it's supposed to work automatically for STL containers and pybind11, but it doesn't work in Open3D for std::vector<T> due to some customizations. Going through a deque enabled it. :-(
There was a problem hiding this comment.
Is the problem with std::vector related to Eigen?
There was a problem hiding this comment.
Probably. We do some custom bindings for Eigen matrices / vectors as well as std::vector and std::vector That's likely disabling pybind11 default bindings. We should switch to pybind11's default bindings. [I don't know the original reason for customization, or if it's still needed.]
Type
Motivation and Context
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Tensor API SamplePointsUniformly for TriangleMesh:
F-Score:
Chamfer Distance, Hausdorff distance