-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #7149 + proposed readme for docker on Windows + fixing typos #7150
base: main
Are you sure you want to change the base?
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good small fixes.
I would mark this PR as breaking change though, since a parameter name changed (with good reason).
It is just a typo fix, but existing calls using named parameters would break.
I cannot say much to the content of the docker windows readme, but there is also docker/README.md where this could be included as a section (or in docs/docker.in.rst as you mentioned.
Not sure if it is a good idea to have 3 different spots documenting docker builds.
Thank you for the feedback
|
Something like that sounds good I think, but somebody else should review that, since I am not using open3d+docker. |
Type
o3d.geometry.TriangleMesh.create_mobius
and ino3d.t.geometry.TriangleMesh.create_mobius
#7149o3d.geometry.TriangleMesh.create_mobius
and ino3d.t.geometry.TriangleMesh.create_mobius
#7149Motivation and Context
o3d.geometry.TriangleMesh.create_mobius
and ino3d.t.geometry.TriangleMesh.create_mobius
:raidus
instead ofradius
as explained in Typo in argument ofo3d.geometry.TriangleMesh.create_mobius
and ino3d.t.geometry.TriangleMesh.create_mobius
#7149docker.in.rst
file in order to appear within https://www.open3d.org/docs/latest/docker.html#building-open3d-in-docker?Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description