Avoid import star (from open3d import *)

[yxlao]

• Replaced from open3d import *
• All python code formatted with YAPF with .style.yapf
• Docs have updated line numbers when referring to the python code

---

This change is 

[griegler]

I like this. This should make the documentation a lot easier to read and to directly use snippets from the examples.

Reviewed 99 of 99 files at r1.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @qianyizh, @syncle, and @yxlao)

---

.style.yapf, line 2 at r1 (raw file):

[style]
based_on_style = google

Can we have this as a target in cmake, or better combine it with the existing make check-style and make apply-style?

---

examples/Python/Basic/convex_hull.py, line 5 at r1 (raw file):

# See license file or visit www.open3d.org for details

# examples/Python/Basic/mesh_sampling.py

convex_hull.py

---

examples/Python/Basic/half_edge_mesh.py, line 12 at r1 (raw file):

def draw_geometries_with_back_face(geometries):
    visualizer = o3d.o3d.visualization.Visualizer()

o3d.o3d ?

---

examples/Python/Basic/half_edge_mesh.py, line 23 at r1 (raw file):

if __name__ == "__main__":
    mesh = o3d.o3d.io.read_triangle_mesh("../../TestData/sphere.ply")

o3d.o3d ?

---

examples/Python/Basic/half_edge_mesh.py, line 24 at r1 (raw file):

if __name__ == "__main__":
    mesh = o3d.o3d.io.read_triangle_mesh("../../TestData/sphere.ply")
    mesh = o3d.o3d.geometry.crop_triangle_mesh(mesh, [-1, -1, -1], [1, 0.6, 1])

o3d.o3d ?

---

examples/Python/Basic/half_edge_mesh.py, line 26 at r1 (raw file):

    mesh = o3d.o3d.geometry.crop_triangle_mesh(mesh, [-1, -1, -1], [1, 0.6, 1])
    mesh.purge()
    mesh = o3d.o3d.geometry.create_half_edge_mesh_from_mesh(mesh)

o3d.o3d ?

---

examples/Python/Basic/half_edge_mesh.py, line 39 at r1 (raw file):

    vertex_colors = 0.75 * np.ones((num_vertices, 3))
    vertex_colors[boundary_vertices, :] = np.array([1, 0, 0])
    mesh.vertex_colors = o3d.o3d.utility.Vector3dVector(vertex_colors)

o3d.o3d ?

---

examples/Python/Basic/mesh_simplification.py, line 5 at r1 (raw file):

# See license file or visit www.open3d.org for details

# examples/Python/Basic/mesh_sampling.py

mesh_simplification.py

---

examples/Python/Basic/mesh_subdivision.py, line 5 at r1 (raw file):

# See license file or visit www.open3d.org for details

# examples/Python/Basic/mesh_sampling.py

mesh_subdivision.py

---

examples/Python/ReconstructionSystem/debug/pairwise_pc_alignment.py, line 10 at r1 (raw file):

import json
import sys
import open3d as o3d

not needed here?

[yxlao]

thanks for the quick review @griegler !

Reviewable status: 90 of 104 files reviewed, 10 unresolved discussions (waiting on @griegler, @qianyizh, and @syncle)

---

.style.yapf, line 2 at r1 (raw file):

Previously, griegler (Gernot) wrote…

Can we have this as a target in cmake, or better combine it with the existing make check-style and make apply-style?

Done.
Good idea

---

examples/Python/Basic/convex_hull.py, line 5 at r1 (raw file):

Previously, griegler (Gernot) wrote…

convex_hull.py

Done.

---

examples/Python/Basic/half_edge_mesh.py, line 12 at r1 (raw file):

Previously, griegler (Gernot) wrote…

o3d.o3d ?

Done.

---

examples/Python/Basic/half_edge_mesh.py, line 23 at r1 (raw file):

Previously, griegler (Gernot) wrote…

o3d.o3d ?

Done.

---

examples/Python/Basic/half_edge_mesh.py, line 24 at r1 (raw file):

Previously, griegler (Gernot) wrote…

o3d.o3d ?

Done.

---

examples/Python/Basic/half_edge_mesh.py, line 26 at r1 (raw file):

Previously, griegler (Gernot) wrote…

o3d.o3d ?

Done.

---

examples/Python/Basic/half_edge_mesh.py, line 39 at r1 (raw file):

Previously, griegler (Gernot) wrote…

o3d.o3d ?

Done.

---

examples/Python/Basic/mesh_simplification.py, line 5 at r1 (raw file):

Previously, griegler (Gernot) wrote…

mesh_simplification.py

Done.

---

examples/Python/Basic/mesh_subdivision.py, line 5 at r1 (raw file):

Previously, griegler (Gernot) wrote…

mesh_subdivision.py

Done.

---

examples/Python/ReconstructionSystem/debug/pairwise_pc_alignment.py, line 10 at r1 (raw file):

Previously, griegler (Gernot) wrote…

not needed here?

Done.

[griegler]

LGTM.
Should we also update the docs:
http://www.open3d.org/docs/compilation.html (at least the gtest part is outdated now)
http://www.open3d.org/docs/contribute.html

Reviewable status: 90 of 104 files reviewed, 10 unresolved discussions (waiting on @griegler, @qianyizh, and @syncle)

[yxlao]

Thanks @griegler , could you click "approve" the PR?
I'll update the docs on gtest and python together in my upcoming doc update PR.

[griegler]

Reviewed 14 of 14 files at r2.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @griegler, @qianyizh, and @syncle)