fix(estate): bug fix (#15254)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
island-is · Jun 18, 2024 · eb70c65 · eb70c65
1 parent 69343fe
commit eb70c65
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 21 deletions.
diff --git a/.../application/templates/estate/src/fields/EstateMembersRepeater/AdditionalEstateMember.tsx b/.../application/templates/estate/src/fields/EstateMembersRepeater/AdditionalEstateMember.tsx
@@ -181,7 +181,7 @@ export const AdditionalEstateMember = ({
             options={relationOptions}
             error={error?.relation}
             backgroundColor="blue"
-            required
+            required={!field.initial}
           />
         </GridColumn>
         {application.answers.selectedEstate ===

diff --git a/libs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx b/libs/application/templates/inheritance-report/src/fields/AssetsRepeater/index.tsx
@@ -413,29 +413,31 @@ const RealEstateNumberField = ({
   }, [queryLoading])
 
   useEffect(() => {
-    const propertyNumber = propertyNumberInput
-      .trim()
-      .toUpperCase()
-      .replace('-', '')
+    if (!props.readOnly) {
+      const propertyNumber = propertyNumberInput
+        .trim()
+        .toUpperCase()
+        .replace('-', '')
 
-    setValue(descriptionFieldName, '')
+      setValue(descriptionFieldName, '')
 
-    if (isValidRealEstate(propertyNumber)) {
-      clearErrors(fieldName)
+      if (isValidRealEstate(propertyNumber)) {
+        clearErrors(fieldName)
 
-      getProperty({
-        variables: {
-          input: {
-            propertyNumber,
+        getProperty({
+          variables: {
+            input: {
+              propertyNumber,
+            },
           },
-        },
-      })
-    } else {
-      if (propertyNumber.length !== 0) {
-        setError(fieldName, {
-          message: formatMessage(m.errorPropertyNumber),
-          type: 'validate',
         })
+      } else {
+        if (propertyNumber.length !== 0) {
+          setError(fieldName, {
+            message: formatMessage(m.errorPropertyNumber),
+            type: 'validate',
+          })
+        }
       }
     }
     // eslint-disable-next-line react-hooks/exhaustive-deps

diff --git a/libs/application/templates/inheritance-report/src/lib/utils/helpers.ts b/libs/application/templates/inheritance-report/src/lib/utils/helpers.ts
@@ -21,8 +21,9 @@ export const currencyStringToNumber = (str: string) => {
   return parseInt(cleanString, 10)
 }
 
-export const isValidString = (string: string | undefined) =>
-  string && /\S/.test(string)
+export const isValidString = (string: string | undefined) => {
+  return string && /\S/.test(string)
+}
 
 export const getEstateDataFromApplication = (
   application: Application<FormValue>,