feat(pension-supplement): Send application #13334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Start implementing sendApplication
karenbjorg
approved these changes
Jan 10, 2024
veronikasif
reviewed
Jan 10, 2024
| } = getPSApplicationAnswers(application.answers) | ||
| const { email } = getPSApplicationExternalData(application.externalData) | ||
|
|
||
| const householdSupplementDTO: ApplicationDTO = { |
There was a problem hiding this comment.
Suggested change
| const householdSupplementDTO: ApplicationDTO = { | |
| const pensionSupplementDTO: ApplicationDTO = { |
There was a problem hiding this comment.
Done, Fixed in the feat/pension-suppliment branch
birkirkristmunds
merged commit 9d4b63e
into
feat/pension-supplement
20 of 22 checks passed
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 15, 2024
* format * fix spelling error * misc fixes * feat(old-age-pension): added scratch payment page (#11712) * home allowance to household supplement * fix message file for contentful * [TS-79 | 81 | 83] minor fixes for employer * [TS-89 | 90 | 91]: add missing things in review screen * [TS-80]: fix so months can be translated * fix(old-age-pension): employers and personal allowance (#11722) * [TS-88]: translate period in review page * [TS-84]: show month in period * Changed PDF display in review screen * feat(old-age-pension): Added new action card functionality (#11742) * Added Conclusion screen and pendingAction/historyLogs to template * Change payment info alert from warning to info * Updated old age pension template * [TS-105] add unit tests + fix lint warnings * Fixed comment in Review screen * set up pension supplement application * [TS-112]: readme + flow chart * [TS-111] Fix lint errors and warnings * changes to readme * [TS-117] Payment page * [TS-118] Reason page * [TS-122] file upload (care at home) * merge * [TS-122, TS-123, TS-124, TS-125, TS-126] Pension supplement file upload * [TS-120]: comment section * [TS-107] General upload * spelling error in messages * [TS-135]: show custome data schema error message + fix namespace in contentful * [TS-58] Changing phone number on confirm page * [TS-111]: fix residence history table * [TS-136] Changing phone number on confirm page * [TS-58] Changing phone number on confirm page * Fixed bank dataSchema validation * [TS-139] Fix divider in Review page * Fix/old age pension alert message (#11766) * fix(old-age-pension): alert message mess application up * fix(old-age-pension): use doesNotRequiredAnswers * clean up * [TS-127] Pension supplement conclusion screen * [TS-111] fix lint errors * fix for alert message * [TS-140] Old age pension - Fix divider in Review page * [TS-129] Application history and pending actions * [TS-128] Additional document required * Fixed history logs for additional documents * Fixed comment width in Review * Fixed getAvailableMonths unit test * Fix/old age pension employers validator (#11771) * fix(old-age-pension): employers answersvalidator * clean up * [TS-144] Only display spouse allowance question in payment page if has spouse * Changed id name in InReview form from parental leave to old age pension * Fixed margin between items on Review page * [TS-147] Add print button to Review page * [TS-149] Format spouse national id in applicant info page * Fixed margin between items on Review page * [TS-145] Add print button to Review page * [TS-150] Bankanúmer birtast ekki á Review síðu * [TS-153] Payment page issue * [TS-144] Only display spouse allowance question in payment page if has spouse - Review * fix typo * Fixed employers ratio monthly * Added margin to Attachments in Review * [TS-159] Fix register employer total ratio field * [TS-160] Fix error when change between monthly and yearly ratio when register employer * feat(old-age-pension): getting connect to TR X-road endpoint (#11948) * chore: nx format:write update dirty files * TS-130 readme + flow chart & TS-169 add margin to pdfs in review * feat(old-age-pension): Update register child page in old age pension application (#11903) * [TS-157] Update register child page in old age pension application * Updated validator to prevent duplicated national id in Child pension * chore: nx format:write update dirty files * Feat/old age pension gagnagatt (#12054) * feat(old-age-pension): added gagnagátt * feat(old-age-pension): Add TR id * Feat/old age pension ts 152 (#12059) * TS-152 * - Renamed the Client Tryggingastofnun to english - Added GetStatusApi * - Rollback * - Rollback changes - Added translation strings * Fix JEST * Fix for unit test * User test API * Changed the TR icelandic name to english * chore: nx format:write update dirty files * fix(old-age-pension): Add event between submitted to inReview (#12063) * Fix/old age pension period show errors (#12069) * fix(old-age-pension): another way to show errors * fix(old-age-pension): change error text * change error text * change error text * chore: nx format:write update dirty files * Feat/old age pension add feature flag (#12088) * feat(old-age-pension): add featureFlag * format * TS-173 list up custody kids in checkboxes + more * TS-192 if no children in custody is selected, register a child * lint & format * fix(old-age-pension): final version for external page (#12136) * nx upgrade * nx upgrade * add markdown to massage * fix link in messages * clean messages * TS-170 - Implement AlertmessageField (#12185) * TS-170 - Implement AlertmessageField * Format code * feat(old-age-pension): Align our states with TR's (#12270) * [TS-165] Align our states with TR's * [TS-205] Add validation to Additional documents required * update unit test after aligning states with TR * chore: nx format:write update dirty files * call bank info api * TS-207 call bank info api from TR * TS-207 fix and format * TS-211 rename for clarity * chore: nx format:write update dirty files * more name changes for readability * chore: nx format:write update dirty files * remove tax level radio button options on payment page * chore: nx format:write update dirty files * make default value 100% for personal allowance * refactor * format * feat(old age pension): Send application (#12355) * -Added sendApplication * First implementation of data object to send to TR with attachments * - Added missing data - Code clean up * - Created sendApplication endpoint - Updated yml schema - Code clean up - Bug fix * - Added jest tests - Fixed unit tests * - Moved Uploads to a type * - prevent sending in childPension and fileUploadChildPension.maintenance if childPensionAddChild is NO * - Changed the ApplicationType Enum to be a number - Changed the TaxOptions Enum to be a number - Made changes to the data sent to TR * Update libs/application/template-api-modules/src/lib/modules/templates/old-age-pension/old-age-pension.service.ts Co-authored-by: veronikasif <[email protected]> * Fix after review * Fix after review * Fix after review minimize the data being sent over to TR * Fix after review and added unit tests * Added application id * Fix after review * Change the applicationType back to string as TR team requested --------- Co-authored-by: veronikasif <[email protected]> * add validation for period to confirm child is under 18 * format * TS-219 wip spouse in nursing home * format * Feat(old age pension): send application fix (#12478) * TS-194 make changes to the Application endpoint * TS-194 Fix the data for the Application endpoint * TS-228 add tax level in bank information page * change taxLevel to number and bank to string * TS-231 Change text household supplement * TS-222 Throw out test and status endpoints * TS-234 Fix personalAllowanceUsage = null error * ts-223 * TS-232 and TS-235 fix space in period screen and make space after residence history * make alert title more consistent * more alert message changes * TS-238 Change text on pension page * revert residence history default value as yes * format * [TS-239]: Update additional documents flow * feat(old-age-pension): Check if applicant is eligible (#12558) * [TS-152] When applicant create new application * Update messages * remove bank info api and spouse in nursing home + calling applicant api * format * [TS-239]: Remove unused file for filesInfoScreen * ts-299 phonenumber is not required but validate if filled in * Fix Eligible endpoint when running locally * remove connected applications code + validation * remove unit tests, text and api calls for connected applications + add info about connected applications to conclusion screen * [TS-194] Save the application on TR servers (#12738) * [TS-263]: Fix progress bar and move one payment per year page * feat(old-age-pension): Make sure additionalDocumentsRequired don't get sent twice to TR when requesting more documents (#12757) * [TS-201]: Mark additionalDocumentsRequired as sent in additionalDocumentsRequired state * [TS-201]: clear previously added documents on entry to additionalDocumentsRequired state * Update libs/application/templates/social-insurance-administration/old-age-pension/src/lib/OldAgePensionTemplate.ts Co-authored-by: veronikasif <[email protected]> --------- Co-authored-by: veronikasif <[email protected]> * [TS-201]: Clean up * 230 - icelandic and foreign bank, call currencies API, only send bank account if changes or registered * [TS-263]: Update formstepper in prerequisites to same as oap form * ts-265 update send application api * TS-230 remove unset bankaccount when switching between icelandic and foreign bank account + use regex validation and format instead of a package (#12818) * remove unused states * feat(old-age-pension): Add dismiss button when editing (#12786) * [TS-259] Add dismiss button when applicant changes application * Fix import after merge conflict * Small fix * Update Codeowners * Refactor * clean up * update flow chart and lifecycles * remove console.log * [TS-263]: Fix and add unit tests * [TS-280] get email, phonenumber and bankaccount from TR (#12841) * chore: nx format:write update dirty files * hide hald old age pension, call clearBankAccountInfo when exiting draft and change error message * remove spouse allowance * isEmpty check * update CODEOWNERS * feat(old-age-pension): Rename TR service, added core folder for shared utils and removed Abort state (#12875) * [TS-289] Refactor TR service * Removed Abort state * Format * removed Abort state transitions test on template * chore: nx format:write update dirty files * Fixed service name * Fixed failing test * use enhancedFetch and ConfigModule * remove unused import * add import to fix error * let template api handle the errors * Fixed typo, removed progress and removed UploadAdditionalDocuments * reduce timeout time for SocialInsuranceAdministrationApi * Removed unused vars * Moved employment validation to dataSchema * [TS-283]: Additional documents required and minor changes from comments on oap * fixed typo * Removed unnecessary useEffect * merge * Update payment info alert msg and fixed failing test * add fileUpload to dataSchema and format * Update conclusion screen * hide 1/2 old age pension and handle undefined bank type * feat(pension-supplement): Update bank account (#12870) * [TS-280] get email, phonenumber and bankaccount from TR * [TS-281] update bank account * Fix old-age pension template onExit action * Fix merge conflicts * Format * Fixed clearBankAccountInfo action * [TS-290] upgrade nx * refactor * add conclusion to formstepper in Prerequisites * [TS-302] Update conclusion screen * [TS-306] Remove unused images * refactor * refactor * [TS-311] Update form stepper * [TS-312] Add dismiss button when applicant changes application * Update submit event * remove depreciated code and add TR to Roles * [TS-281] update bank account * remove eslint-disable * remove unused period component in oap * update readme and flow chart * [TS-323] fix period * Updated getAvailableYears and getAvailableMonths in ps application * add feature flag * add fetch additionalDocumentsRequired for pension supplement to sia service * review and add unit tests * Updated imports * Use sia core messages * Add file upload shared props to constants in sia core * [TS-282]: Add eligible API * feat(pension-supplement): Send application (#13334) * - Add reasons to yaml - Start implementing sendApplication * Implement attachments * Fix copy/paste naming * format, isEligible function * chore: nx format:write update dirty files * chore: nx format:write update dirty files * delete answer validation and add file upload validation to dataschema, change upload accepted and remove unused code --------- Co-authored-by: qdd1 <[email protected]> Co-authored-by: Veronika Sif <[email protected]> Co-authored-by: veronikasif <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: birkirkristmunds <[email protected]> Co-authored-by: bkristmundsson <[email protected]> Co-authored-by: ylfahfa <[email protected]> Co-authored-by: andes-it <[email protected]> Co-authored-by: ylfahfa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
Attach a link to issue if relevant
What
Specify what you're trying to achieve
Why
Specify why you need to achieve this
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist: