feat(fa): Adding muni settings to summary form #14869
Conversation
This reverts commit d9691c5.
…g-settings-in-veita-about-children
…g-settings-in-veita-about-children
…g-settings-in-veita-about-children
…g-settings-in-veita-about-children
…g-muni-settings-to-summary
MargretFinnboga
changed the title
WalkthroughThe recent updates focus on enhancing the functionality and user interface of the financial aid application template. Key changes include the removal of Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- libs/application/templates/financial-aid/src/fields/Summary/ChildrenInfo.tsx (2 hunks)
- libs/application/templates/financial-aid/src/fields/Summary/SummaryForm.tsx (3 hunks)
- libs/application/templates/financial-aid/src/lib/messages/summaryForm.ts (1 hunks)
Additional Context Used
Path-based Instructions (3)
libs/application/templates/financial-aid/src/fields/Summary/ChildrenInfo.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/financial-aid/src/fields/Summary/SummaryForm.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/financial-aid/src/lib/messages/summaryForm.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (5)
libs/application/templates/financial-aid/src/fields/Summary/ChildrenInfo.tsx (1)
52-52: Approved the changes in grid layout and margin settings, enhancing responsiveness and consistency.Also applies to: 60-61
libs/application/templates/financial-aid/src/fields/Summary/SummaryForm.tsx (3)
4-10: Confirmed the new imports are used appropriately for handling children's aid functionality.
58-61: Approved the logic for displaying children's aid alerts based on relevant conditions.
93-118: Approved the conditional rendering of alert messages, which enhances clarity of information based on user-specific circumstances.libs/application/templates/financial-aid/src/lib/messages/summaryForm.ts (1)
48-60: Approved the new message definitions for children's aid alerts, which are correctly implemented and support enhanced functionality.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14869 +/- ##
==========================================
- Coverage 37.04% 36.97% -0.08%
==========================================
Files 6331 6331
Lines 129120 129105 -15
Branches 36852 36849 -3
==========================================
- Hits 47835 47731 -104
- Misses 81285 81374 +89 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 36 Total Test Services: 0 Failed, 35 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
* adding sortable feature * Revert "adding sortable feature" This reverts commit d9691c5. * adding more detail for api * removing white space break just adding html element to the db * adding settings children aid * adding children aid to places * children aid added from backend to front, just need to make it appear * adding radiobuttons to update * adding alert banners depending children aid from muni --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
...
Sýna upphæðir v. barna í útreikningum í umsókn ef við á
What
Why
Screenshots / Gifs
-- If childrenaid is APPLICANT --
Checklist:
Summary by CodeRabbit
New Features
Updates
Removed
useIntl()for formatting messages in the ChildrenInfo component.