-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rights-portal): remove feature flag #14979
Conversation
WalkthroughThe Changes
Tip Early Access Features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/api/domains/rights-portal/src/lib/rightsPortal.module.ts (1 hunks)
Additional Context Used
Path-based Instructions (1)
libs/api/domains/rights-portal/src/lib/rightsPortal.module.ts (1)
Pattern
libs/**/*
: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (1)
libs/api/domains/rights-portal/src/lib/rightsPortal.module.ts (1)
20-20
: Removal ofFeatureFlagModule
appears clean and well-integrated.
Datadog ReportAll test runs ✅ 9 Total Test Services: 0 Failed, 9 Passed Test Services
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14979 +/- ##
==========================================
- Coverage 37.18% 37.13% -0.05%
==========================================
Files 6374 6373 -1
Lines 129762 129703 -59
Branches 37033 36999 -34
==========================================
- Hits 48246 48161 -85
- Misses 81516 81542 +26
Flags with carried forward coverage won't be shown. Click here to find out more. see 91 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
What
Remove feature flag module
Why
Clean up
Screenshots / Gifs
Attach Screenshots / Gifs to help reviewers understand the scope of the pull request
Checklist:
Summary by CodeRabbit