fix(application-system): empty title for formStepper #15185
Conversation
WalkthroughThe changes in Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FormStepper
participant UI
User->>FormStepper: Load FormStepper
FormStepper->>UI: Map child elements and sections
alt Text content is valid
UI->>User: Render child elements and sections
else Text content is null
UI->>User: Skip rendering for null text elements
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 5 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15185 +/- ##
==========================================
- Coverage 36.98% 36.98% -0.01%
==========================================
Files 6419 6419
Lines 130969 130974 +5
Branches 37497 37498 +1
==========================================
Hits 48439 48439
- Misses 82530 82535 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/application/ui-shell/src/components/FormStepper.tsx (2 hunks)
Additional context used
Path-based instructions (1)
libs/application/ui-shell/src/components/FormStepper.tsx (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Biome
libs/application/ui-shell/src/components/FormStepper.tsx
[error] 68-68: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.
[error] 104-104: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.
Additional comments not posted (1)
libs/application/ui-shell/src/components/FormStepper.tsx (1)
100-119: Ensure conditional rendering logic is robust and maintainable.The implementation of conditional rendering based on the presence of
sectionTitleis clear and aligns with the PR objectives to handle null text content effectively.Tools
Biome
[error] 104-104: Avoid using the index of an array as key property in an element. (lint/suspicious/noArrayIndexKey)
This is the source of the key value.
The order of the items may change, and this also affects performances and component state.
Check the React documentation.
jonnigs
added
the
deprecated:automerge
* fix: empty title for formStepper * fix: use the constant I defined --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* fix: empty title for formStepper * fix: use the constant I defined --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
What
Don't render out steps in the formStepper if the title is empty
Why
To have the same behaviour as the discontinued core formStepper
Screenshots / Gifs
Previously:
Now:
Checklist:
Summary by CodeRabbit
FormSteppercomponent to handle cases where text elements are null, ensuring proper conditional rendering based on the presence of valid text content.