Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(j-s): Left align table values #16002

Merged
merged 2 commits into from
Sep 13, 2024
Merged

chore(j-s): Left align table values #16002

merged 2 commits into from
Sep 13, 2024

Conversation

oddsson
Copy link
Member

@oddsson oddsson commented Sep 13, 2024

Left align table values

Asana

What

Left align "sent" table header and value in additional documents table

Why

The alignment was not consistent

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • Style
    • Adjusted text alignment for date and submission information in the Case File Table for a more consistent visual presentation.

@oddsson oddsson requested a review from a team as a code owner September 13, 2024 13:35
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Walkthrough

The changes involve the modification of the Text component properties within the CaseFileTable.tsx file. Specifically, the textAlign property has been removed from two instances of the component that display date and submission information. This alteration affects the visual presentation of the text in the table, aiming for a more consistent styling approach.

Changes

File Change Summary
.../CaseFileTable/CaseFileTable.tsx Removed textAlign property from two Text component instances displaying date and submission info.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CaseFileTable
    participant TextComponent

    User->>CaseFileTable: Request to view case file
    CaseFileTable->>TextComponent: Render creation date
    CaseFileTable->>TextComponent: Render submission info
    TextComponent-->>CaseFileTable: Display formatted text without alignment
    CaseFileTable-->>User: Show case file with updated text display
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.84%. Comparing base (dddefda) to head (72a6abc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16002   +/-   ##
=======================================
  Coverage   36.84%   36.84%           
=======================================
  Files        6718     6718           
  Lines      137732   137732           
  Branches    39159    39159           
=======================================
  Hits        50753    50753           
  Misses      86979    86979           
Flag Coverage Δ
judicial-system-web 28.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/components/Table/CaseFileTable/CaseFileTable.tsx 7.69% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dddefda...72a6abc. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Sep 13, 2024

Datadog Report

Branch report: j-s/left-alignment
Commit report: 4697c5f
Test service: judicial-system-web

✅ 0 Failed, 338 Passed, 0 Skipped, 1m 14.28s Total Time
➡️ Test Sessions change in coverage: 1 no change

@gudjong gudjong added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Sep 13, 2024
@kodiakhq kodiakhq bot merged commit 94f993e into main Sep 13, 2024
30 checks passed
@kodiakhq kodiakhq bot deleted the j-s/left-alignment branch September 13, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants