fix(regulations-admin): Update styling. Update presigned query. #16007
Conversation
WalkthroughThe pull request introduces several changes across multiple files, focusing on semantic adjustments in text descriptions and enhancements to security and auditing in GraphQL mutations. Key modifications include altering the phrasing from "Breytt af" to "Breytt með" in various components and adding decorators to enforce security measures in the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16007 +/- ##
==========================================
- Coverage 36.81% 36.81% -0.01%
==========================================
Files 6721 6721
Lines 137870 137863 -7
Branches 39197 39193 -4
==========================================
- Hits 50755 50749 -6
+ Misses 87115 87114 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 3 Total Test Services: 0 Failed, 3 Passed |
thordurhhh
added
the
deprecated:automerge
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (5)
- apps/web/components/Regulations/RegulationTexts.types.ts (1 hunks)
- libs/api/domains/regulations/src/lib/api-domains-regulations.resolver.ts (2 hunks)
- libs/portals/admin/regulations-admin/src/components/TaskList.tsx (1 hunks)
- libs/portals/admin/regulations-admin/src/components/impacts/ImpactListItem.tsx (1 hunks)
- libs/portals/admin/regulations-admin/src/utils/dataHooks.ts (1 hunks)
Files skipped from review due to trivial changes (3)
- apps/web/components/Regulations/RegulationTexts.types.ts
- libs/portals/admin/regulations-admin/src/components/TaskList.tsx
- libs/portals/admin/regulations-admin/src/components/impacts/ImpactListItem.tsx
Additional context used
Path-based instructions (2)
libs/api/domains/regulations/src/lib/api-domains-regulations.resolver.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/portals/admin/regulations-admin/src/utils/dataHooks.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
Additional comments not posted (3)
libs/api/domains/regulations/src/lib/api-domains-regulations.resolver.ts (3)
3-5: LGTM!The imports are necessary for applying authentication and authorization to the GraphQL mutation. The code adheres to the project's conventions and best practices.
10-10: LGTM!The import is necessary for applying auditing to the GraphQL mutation. The code adheres to the project's conventions and best practices.
28-35: LGTM!The decorators applied to the
createPresignedPostmutation enhance its security and auditing capabilities:
- The
@Auditdecorator logs actions related to this mutation, providing a namespace for tracking purposes.- The
@UseGuardsdecorator applies authentication and authorization checks, ensuring that only users with the appropriate permissions can invoke this mutation.- The
@Mutationdecorator explicitly sets the mutation's name toregulationCreatePresignedPost, which clarifies its purpose within the GraphQL schema.These changes collectively improve the functionality by enforcing security measures and enabling auditing for the mutation. The code adheres to the project's conventions and best practices.
oddsson
added
deprecated:automerge
thordurhhh
removed
the
deprecated:automerge
lodmfjord
added
deprecated:automerge
What
Update styling. Update presigned query.
Why
Bugfixing UI.
Bugfixing presigned post.
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Documentation