feat(web): Generic List - Stop date from taking up space if it is not present #17188
Conversation
RunarVestmann
added
the
deprecated:automerge
WalkthroughThe pull request introduces several modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17188 +/- ##
==========================================
- Coverage 35.76% 35.75% -0.01%
==========================================
Files 6931 6931
Lines 147942 147942
Branches 42160 42166 +6
==========================================
- Hits 52918 52904 -14
- Misses 95024 95038 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 0 Skipped, 24.81s Total Time |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/web/components/GenericList/GenericList.tsx (1)
176-200: Consider simplifying the layout logicThe current implementation uses complex conditional spans and duplicates icon positioning logic. Consider refactoring to:
- Extract the icon rendering logic into a separate component
- Simplify the column span calculations
- <GridRow> - <GridColumn - span={ - !item.date && icon - ? ['10/12', '10/12', '10/12', '10/12', '11/12'] - : '1/1' - } - > - <Text variant="h3" as="span" color="blue400"> - <Hyphen>{item.title}</Hyphen> - </Text> - </GridColumn> - {!item.date && icon && ( - <GridColumn span={['2/12', '2/12', '2/12', '2/12', '1/12']}> - <Box display="flex" justifyContent="flexEnd"> - <Icon - size="medium" - type="outline" - color="blue400" - icon={icon} - /> - </Box> - </GridColumn> - )} - </GridRow> + <Box display="flex" alignItems="center" justifyContent="space-between"> + <Box flexGrow={1}> + <Text variant="h3" as="span" color="blue400"> + <Hyphen>{item.title}</Hyphen> + </Text> + </Box> + {!item.date && icon && ( + <Box marginLeft={2}> + <Icon + size="medium" + type="outline" + color="blue400" + icon={icon} + /> + </Box> + )} + </Box>
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
apps/web/components/GenericList/GenericList.tsx(3 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/components/GenericList/GenericList.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (2)
apps/web/components/GenericList/GenericList.tsx (2)
89-93: LGTM! Clean implementation of conditional date rendering
The conditional rendering of the date field effectively addresses the PR objective, ensuring the date doesn't take up space when not present.
159-175: LGTM! Effective implementation of conditional date container
The date container implementation with proper spacing and icon alignment matches the PR objective.
… present (#17188) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Generic List - Stop date from taking up space if it is not present
Screenshots / Gifs
Before
After
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Style