fix(j-s): Add missing court case number to info card

[oddsson]

Add missing court case number to info card

Asana

What

The InfoCard component displayed to prosecutor users in indictments that have either been sent to the court or ruled on should show the court case number. This PR implements that.

Why

Prosecutors need to see the court case number to effectively work the case.

Screenshots / Gifs

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Enhanced case information display by adding the court case number to the InfoCard component.

[coderabbitai]

Walkthrough

The pull request introduces a new variable courtCaseNumber to the InfoCardActiveIndictment component. This change enhances the information displayed in the case information section by adding the court case number to the existing set of case details. The modification is straightforward, involving the addition of a single variable to the items array within the component's rendering logic.

Changes

File	Change Summary
apps/judicial-system/web/src/components/InfoCard/InfoCardActiveIndictment.tsx	Added courtCaseNumber to the destructured return values of useInfoCardItems hook and included it in the items array

Possibly related PRs

• feat(j-s): Indictment View Tag #14922: Modifies the InfoCard component, related to case information display
• fix(j-s): Handle no defender assigned in indictment case InfoCard #15414: Addresses information display in InfoCard for cases without a defender
• fix(j-s): Fix InfoCard #16830: Fixes InfoCard component display
• feat(j-s): Show district court abbreviation on mobile  #17075: Enhances display of court case numbers with abbreviations
• feat(j-s): Add court name abbr. to prison cases table #17171: Adds court name abbreviations to prison cases table

Suggested labels

automerge

Suggested reviewers

• thorhildurt

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@c222f72). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17348   +/-   ##
=======================================
  Coverage        ?   35.68%           
=======================================
  Files           ?     6929           
  Lines           ?   148737           
  Branches        ?    42504           
=======================================
  Hits            ?    53079           
  Misses          ?    95658           
  Partials        ?        0           

Flag	Coverage Δ
judicial-system-web	27.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...c/components/InfoCard/InfoCardActiveIndictment.tsx	10.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c222f72...5175383. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: j-s/court-case-number-info-card
Commit report: e62323d
Test service: judicial-system-web

✅ 0 Failed, 344 Passed, 0 Skipped, 56.45s Total Time
➡️ Test Sessions change in coverage: 1 no change

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

apps/judicial-system/web/src/components/InfoCard/InfoCardActiveIndictment.tsx (1)

49-49: Consider a fallback or context for missing values.

If courtCaseNumber can be absent under certain conditions, you may want to provide a fallback or handle it gracefully to maintain a consistent user experience.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0a1eec and 2e1d46c.

📒 Files selected for processing (1)

• apps/judicial-system/web/src/components/InfoCard/InfoCardActiveIndictment.tsx (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

apps/judicial-system/web/src/components/InfoCard/InfoCardActiveIndictment.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

[thorhildurt]

lgtm 👌 One thing I noticed in the figma screenshot vs the PR screen shot is that the info fields in the form are not in the same order. But if we need to fix that we can prob do that in a follow up task.

[oddsson]

lgtm 👌 One thing I noticed in the figma screenshot vs the PR screen shot is that the info fields in the form are not in the same order. But if we need to fix that we can prob do that in a follow up task.

The order of items in the info cards are all over the place. There is a task in Asana to implement a consistent order of info card items so it will be fixed there.