fix(web): Service web - FormProvider moved to top of component #17495
Conversation
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options. WalkthroughThe pull request introduces significant changes to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Affected services are: web, Deployed services: web. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17495 +/- ##
==========================================
- Coverage 35.61% 35.59% -0.02%
==========================================
Files 7015 7015
Lines 150339 150385 +46
Branches 42981 42999 +18
==========================================
- Hits 53541 53533 -8
- Misses 96798 96852 +54
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 5 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
RunarVestmann
added
deprecated:automerge
RunarVestmann
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/web/components/ServiceWeb/Forms/StandardForm/StandardForm.tsx (2)
932-979: Improve error handling and placeholder text in state entity selection.Consider these improvements:
- Simplify error handling by directly using
errors.rikisadili?.messageinstead of converting to string.- The placeholder text is using
requiredMessagenamespace key instead ofplaceholder.-errorMessage={errors?.rikisadili?.message?.toString()} +errorMessage={errors?.rikisadili?.message} -placeholder={fn( - 'rikisadili', - 'requiredMessage', - 'Leitaðu að þinni stofnun', -)} +placeholder={fn( + 'rikisadili', + 'placeholder', + 'Leitaðu að þinni stofnun', +)}
1148-1162: Prevent potential button state flicker during form submission.The button's disabled state should consider both the loading and submission states to prevent any flash of enabled state.
<Button type="submit" variant="primary" icon="arrowForward" loading={loading} -disabled={!canSubmit} +disabled={!canSubmit || loading} >
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/components/ServiceWeb/Forms/StandardForm/StandardForm.tsx(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/components/ServiceWeb/Forms/StandardForm/StandardForm.tsx (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/web/components/ServiceWeb/Forms/StandardForm/StandardForm.tsx (1)
776-779: Well-structured form context provider placement!The FormProvider is correctly positioned at the top level, ensuring form context availability throughout the component hierarchy.
Service web - FormProvider moved to top of component
Summary by CodeRabbit
New Features
namefield with a newrikisadiliselect componentsyslumadurfield to use a select component with predefined optionsBug Fixes
The changes streamline the form's rendering and validation logic, providing a more robust and user-friendly form experience.