fix(web): Change default 404 log message #17629
Conversation
WalkthroughThe pull request introduces a minor modification to the logging message in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17629 +/- ##
==========================================
+ Coverage 35.56% 35.58% +0.01%
==========================================
Files 7033 7031 -2
Lines 150539 150338 -201
Branches 42976 42911 -65
==========================================
- Hits 53545 53502 -43
+ Misses 96994 96836 -158
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/utils/getServerSidePropsWrapper.ts (1)
53-56: LGTM! Consider standardizing the log message format.The change appropriately removes the word "error" from the info log while maintaining proper error handling. The logging level is correct as 404s are expected responses, not errors.
Consider standardizing the default log message to follow a more structured format:
- error.title || '404 status code, page not found on web', + error.title || '[web] 404: Page not found',This format is more concise and follows common logging patterns where:
- Service/component is wrapped in brackets
- Status code precedes the description
- Message is brief but descriptive
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/utils/getServerSidePropsWrapper.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/web/utils/getServerSidePropsWrapper.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Datadog ReportAll test runs ✅ 8 Total Test Services: 0 Failed, 7 Passed Test Services
🔻 Code Coverage Decreases vs Default Branch (1)
|
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 0 Skipped, 26.91s Total Time |
Change default 404 log message
What
Checklist:
Summary by CodeRabbit