chore(ci): Upgrade dependencies and change package managers

[peturgq]

Upgrade dependencies and change package managers

To start off we're going to upgrade a few things:

• Upgrade Yarn to berry(2+)
• Upgrade Node to 18
• Upgrade Typescript to 4.4.2
• Upgrade graphql to 16.6.0
• Upgrade esbuild to 0.15.7
• Upgrade jest to 28.1.3
• Upgrade apollo-server-express to 3.10.2

Positive side effect of upgrading node and typescript is you are forced to update some other packages.

Yarn is being upgraded to berry because this allows us to utilize some new methods to optimize things surrounding node_modules in our builds.

Typescript is being upgraded because of: yarnpkg/berry#3275
The changes introduced some more type safety enforcing in the compiler, so some additional changes in code were necessary.

Issues pending fixes

• Running code coverage finds broken code which is usually caused by the new typescript compiler being stricter

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1205215248005429

[codecov]

Codecov Report

Merging #8397 (5f9463a) into main (6bf6221) will decrease coverage by 0.25%.
The diff coverage is 27.27%.

❗ Current head 5f9463a differs from pull request most recent head 87c1a21. Consider uploading reports for the commit 87c1a21 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8397      +/-   ##
==========================================
- Coverage   31.12%   30.86%   -0.26%     
==========================================
  Files        3009     2945      -64     
  Lines       54558    53033    -1525     
  Branches    14562    14042     -520     
==========================================
- Hits        16982    16370     -612     
+ Misses      37576    36663     -913     

Flag	Coverage Δ
air-discount-scheme-backend	79.64% <ø> (+0.09%)	⬆️
air-discount-scheme-web	0.00% <0.00%> (ø)
api	5.59% <25.00%> (-0.11%)	⬇️
api-catalogue-services	81.81% <ø> (ø)
api-domains-criminal-record	47.50% <ø> (ø)
api-domains-driving-license	45.52% <ø> (ø)
api-domains-education	18.95% <ø> (ø)
api-domains-health-insurance	39.59% <ø> (ø)
api-domains-license-service	6.72% <ø> (-3.94%)	⬇️
api-domains-mailchimp	70.83% <ø> (ø)
api-domains-mortgage-certificate	35.18% <ø> (ø)
api-domains-payment-schedule	49.60% <ø> (ø)
application-api-files	34.79% <ø> (ø)
application-core	69.57% <ø> (-0.06%)	⬇️
application-templates-criminal-record	2.25% <ø> (ø)
application-templates-driving-license	7.12% <ø> (+0.02%)	⬆️
application-templates-example-payment	10.41% <ø> (ø)
application-templates-financial-aid	7.30% <ø> (ø)
application-templates-health-insurance	28.30% <ø> (ø)
application-templates-parental-leave	26.29% <ø> (+0.66%)	⬆️
application-ui-components	2.26% <ø> (ø)
application-ui-shell	48.54% <ø> (+0.44%)	⬆️
auth-admin-web	2.45% <ø> (-0.01%)	⬇️
auth-nest-tools	10.89% <ø> (+0.10%)	⬆️
auth-react	66.01% <ø> (ø)
clients-driving-license	6.41% <ø> (ø)
clients-middlewares	93.26% <ø> (ø)
clients-payment-schedule	2.43% <ø> (ø)
clients-rsk-company-registry	57.31% <ø> (ø)
clients-rsk-personal-tax-return	26.74% <ø> (ø)
clients-syslumenn	73.17% <ø> (-0.95%)	⬇️
clients-zendesk	68.00% <ø> (ø)
cms-translations	32.65% <ø> (ø)
content-search-index-manager	95.65% <ø> (ø)
download-service	54.24% <ø> (ø)
file-storage	29.62% <ø> (ø)
health-insurance	35.80% <ø> (ø)
icelandic-names-registry-backend	59.11% <ø> (ø)
infra-tracing	47.82% <ø> (ø)
island-ui-core	28.17% <ø> (-0.01%)	⬇️
judicial-system-api	1.23% <0.00%> (+0.04%)	⬆️
judicial-system-audit-trail	87.35% <ø> (-0.29%)	⬇️
judicial-system-formatters	67.82% <ø> (+1.99%)	⬆️
judicial-system-message	?
judicial-system-message-handler	36.73% <ø> (+8.44%)	⬆️
judicial-system-scheduler	63.63% <ø> (ø)
judicial-system-types	60.86% <ø> (+0.11%)	⬆️
judicial-system-web	19.16% <0.00%> (+0.28%)	⬆️
localization	10.25% <ø> (ø)
logging	27.41% <ø> (ø)
message-queue	70.74% <ø> (ø)
nest-audit	79.77% <ø> (ø)
nest-feature-flags	89.13% <ø> (-1.62%)	⬇️
nest-problem	84.45% <100.00%> (+0.10%)	⬆️
nest-sequelize	94.44% <ø> (ø)
nest-swagger	93.18% <ø> (ø)
nova-sms	75.00% <ø> (ø)
regulations	16.90% <ø> (ø)
residence-history	85.00% <ø> (ø)
service-portal-health	13.63% <ø> (ø)
services-auth-personal-representative-public	89.47% <ø> (+0.22%)	⬆️
services-auth-public-api	98.95% <ø> (+1.63%)	⬆️
services-user-notification	43.15% <ø> (ø)
shared-components	73.57% <ø> (ø)
shared-form-fields	32.08% <ø> (ø)
shared-utils	51.89% <ø> (+1.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[cypress]

---

Test summary

183 • 0 • 5 • 0 • 0

---

Run details

Project	island.is
Status	Passed
Commit	94b3401 ℹ️
Started	Oct 18, 2022 10:58 AM
Ended	Oct 18, 2022 11:16 AM
Duration	18:31 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 102

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[peturgq]

@gudjong

One thing
Agree, there is no need to wait.

If we did not use await there we hit the following error:
'Can not use queue until nest application bootstrapping has finished'

[gudjong]

@gudjong

One thing
Agree, there is no need to wait.

If we did not use await there we hit the following error: 'Can not use queue until nest application bootstrapping has finished'

That is surprising, but I will accept the change. This code has change and we may need to revisit this when you merge with main.

[peturgq]

We made a separate issue for fixing remaining type-safety violations:
#8705

We looked into some of them but they require more digging - The main issue with having this PR not merged is that it is time sensitive, the more we wait the more we could expect new code from main to cause the new typescript compiler to fail.