Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Powerbi richtext embed slice #8703

Merged
merged 6 commits into from
Oct 18, 2022

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Oct 14, 2022

Powerbi richtext embed slice

What

  • Add PowerBiSlice content type to Contentful which allows you to embed PowerBi reports and dashboards

Why

  • Many organizations have reports they'd like to show on the web

Screenshots / Gifs

image

## Checklist:
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #8703 (4c0e732) into main (da9c333) will decrease coverage by 0.00%.
The diff coverage is 7.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8703      +/-   ##
==========================================
- Coverage   31.49%   31.48%   -0.01%     
==========================================
  Files        2962     2964       +2     
  Lines       53853    53865      +12     
  Branches    14315    14318       +3     
==========================================
+ Hits        16961    16962       +1     
- Misses      36892    36903      +11     
Flag Coverage Δ
api 5.69% <ø> (ø)
api-domains-driving-license 45.52% <ø> (ø)
api-domains-license-service 10.65% <ø> (ø)
api-domains-mailchimp 70.83% <ø> (ø)
application-system-api 76.84% <ø> (ø)
application-templates-driving-license 7.10% <ø> (ø)
application-ui-shell 48.09% <ø> (ø)
auth-admin-web 2.45% <ø> (ø)
cms-translations 32.65% <ø> (ø)
judicial-system-api 1.19% <ø> (ø)
judicial-system-backend 81.36% <ø> (ø)
judicial-system-web 18.87% <ø> (ø)
services-auth-personal-representative 92.11% <ø> (ø)
services-auth-personal-representative-public 89.24% <ø> (ø)
services-auth-public-api 97.32% <ø> (ø)
services-user-notification 43.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@RunarVestmann RunarVestmann marked this pull request as ready for review October 16, 2022 10:57
@RunarVestmann RunarVestmann requested review from a team as code owners October 16, 2022 10:57
@RunarVestmann RunarVestmann added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 18, 2022
@kodiakhq kodiakhq bot merged commit 6bf6221 into main Oct 18, 2022
@kodiakhq kodiakhq bot deleted the feature/powerbi-richtext-embed-slice branch October 18, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants