fix(driving-license-application): Name mapping and formatting #8711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdiljar
added
the
deprecated:automerge
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8711 +/- ##
==========================================
- Coverage 31.49% 31.49% -0.01%
==========================================
Files 2962 2962
Lines 53859 53861 +2
Branches 14314 14316 +2
==========================================
Hits 16961 16961
- Misses 36898 36900 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
albinagu
approved these changes
Oct 17, 2022
alexdiljar
added a commit
that referenced
this pull request
Oct 18, 2022
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
alexdiljar
added a commit
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing formatting for Operating License time.
If user get driving assessment after the application is created the driving teachers name will not show up in summary. Put a condition on this field for now so it only shows for b-temp applications. There are some changes coming the driving license application, will reassess this functionality then. This is just to fix the bug for now.
Also some minor cleanup.
Checklist: