Accept source map input for the visitor #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect. If a source map is explicitly passed, prefer that, otherwise try and pluck an inline source map that babel may have already parsed from the file content.
jwbay
force-pushed
the
accept-source-map
branch
2 times, most recently
from
492c325 to
a5efe28
Compare
6 tasks
These can take up a lot of memory for large projects, especially if the original source is inlined into the source map.
jwbay
force-pushed
the
accept-source-map
branch
from
a5efe28 to
88eeffa
Compare
|
@jwbay thanks a ton for the awesome contributions, I'm exited to see this make it upstream. |
|
@jwbay please take this for a spin:
|
|
Tested and everything looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a source map is explicitly passed, prefer that, otherwise try and pluck an inline source map that babel may have already parsed from the file content.
Counterpart to - https://github.com/istanbuljs/istanbul-lib-instrument/pull/23/files#diff-c07343828715f64179d26d4c237cb63c
Ref - istanbuljs-archived-repos/istanbul-lib-source-maps#4
Context - upstream PR for jestjs/jest#2290. Jest provides instrumentation using babel-plugin-istanbul, and currently there's disparity with source map support between
createInstrumenter().instrumentSync()and this babel plugin. This PR resolves that so both approaches can thread a source map through and have it attached to coverage.