Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more exclude glob patterns #199

Merged
merged 1 commit into from
Mar 21, 2016

Conversation

kentcdodds
Copy link
Member

I personally use (and teach) that applications should co-locate test files and source code, which is where the *.test.js comes from.

The React community uses the __tests__ convention.

Happy to make any changes you'd like to see :-)

@bcoe
Copy link
Member

bcoe commented Mar 21, 2016

@kentcdodds this looks great \o/ happy to make things better fit your usecase.

@novemberborn
Copy link
Contributor

:shipit:

bcoe added a commit that referenced this pull request Mar 21, 2016
@bcoe bcoe merged commit deee980 into istanbuljs:master Mar 21, 2016
@kentcdodds kentcdodds deleted the pr/more-test-file-conventions branch March 21, 2016 20:42
@kentcdodds
Copy link
Member Author

Any chance we can see a release of this anytime soon? I'm updating my workshop which uses nyc and follows these conventions and I'd love to not have to teach people to exclude the test files :-)

Thanks!

@bcoe
Copy link
Member

bcoe commented Apr 4, 2016

@kentcdodds yes, I will get a release out the door ASAP (we've been trying to solve a frustrating issue with Node 5.8.0, and have been blocking on a few things upstream).

Could you give this a shot:

npm i nyc@bundle-test

it's an experimental release candidate, and should have your changes included.

@kentcdodds
Copy link
Member Author

Oh dear... Turns out my glob was wrong :-/ *.test.js should be **/*.test.js. I'm not sure why, but do you mind if I make another PR to fix this and get that in the upcoming release?

@bcoe
Copy link
Member

bcoe commented Apr 4, 2016

@kentcdodds yep, happy to land that patch; I'll do my best to juggle everything on the wire and get something out this week 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants