-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add produceSourceMap option #393
Conversation
This allows the user to control the source map output post instrumentation. Not fully straightforward right now, but when combined with a fork of source-map-support that has inline support (or placing the files in the proper location), end to end covered source maps can be achieved. For runtime source-map-support, see evanw/node-source-map-support#118. Will be forking to @kpdecker/source-map-support soon, since the canonical project appears to be dead.
The above PR is published under
|
Changes Unknown when pulling 5f531b7 on kpdecker:expose-source-map into * on istanbuljs:master*. |
Hey @kpdecker sorry for the slow turn around on this; haven't had nearly as much time to work on OSS software lately as I would like. I like where you're going with this, a couple comments:
|
Simplify the API and add tests.
@bcoe Added tests showing that this does fix #285 when |
Changes Unknown when pulling 4e8c205 on kpdecker:expose-source-map into * on istanbuljs:master*. |
@kpdecker bringing this issue back to your attention, have you tested this branch with |
@bcoe, I've been using this for all of my work projects off of @kpdecker/node-source-map-support for about a month now and it is working just fine. |
I'll update this PR to restore the dependency back to the standard package. |
Changes Unknown when pulling be92706 on kpdecker:expose-source-map into * on istanbuljs:master*. |
@@ -1,12 +1,13 @@ | |||
function InstrumenterIstanbul (cwd) { | |||
function InstrumenterIstanbul (cwd, options) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should 'use strict';
at the top of these files.
Other than minor style nitpicks, this LGTM :) curious if there's more test coverage we could get though? |
This allows the user to control the source map output post instrumentation.
Not fully straightforward right now, but when combined with a fork of source-map-support that has inline support (or placing the files in the proper location), end to end covered source maps can be achieved.
For runtime source-map-support, see evanw/node-source-map-support#118. Will be forking to @kpdecker/source-map-support soon, since the canonical project appears to be dead.
Fix for #285 (When combined with the above)