Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to execute methods when the drop down is opened or closed #5

Merged
merged 1 commit into from
May 8, 2014

Conversation

Reboog711
Copy link

In this change; I added the ability to execute methods when the drop down is opened or closed. It would be used something like this:

In the controller, you'd have code like this:

$scope.onMultiSelectClose = function onMultiSelectClose(){
console.log('on multi-select close');
}

$scope.onMultiSelectOpen= function onMultiSelectOpen(){
console.log('on multi-select open');
}

isteven added a commit that referenced this pull request May 8, 2014
Added the ability to execute methods when the drop down is opened or closed
@isteven isteven merged commit 32820f9 into isteven:master May 8, 2014
@isteven
Copy link
Owner

isteven commented May 8, 2014

Thanks Reboog711 for the updates. So I assume the element would be something like:

<div multi-select ... on-popupopen="onMultiSelectOpen" on-popupclose="onMultiSelectClose"></div> 

Am I correct?

@Reboog711
Copy link
Author

I guess the HTML got stripped out of my original comment. But, yes. I'd put parenthesis on the function calls like this:

<div multi-select ... on-popupopen="onMultiSelectOpen()" on-popupclose="onMultiSelectClose()"></div> 

@isteven
Copy link
Owner

isteven commented May 9, 2014

Noted. I will most likely modify your code a bit, mainly because I wanted to add more event handlers. Had this in mind for quite some time but rather busy recently, so yeah.

Thanks for the contribution, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants