fix proxy build broken by global_dictionary.yaml #615
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a comment in https://github.com/istio/api/pull/605/files but think it's faster to send out a PR directly.
@mandarjog
Line 316
- "-"
break the proxy build as create_global_dictionary.py parse it to:""-"",
which is invalid in.cc
file.Could you suggest the proper way to fix this? Should we just remove the
"
or make it\"-\"
or even update the script?