Set release managers as CODEOWNERS for release-1.7 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
|
/retest |
|
/retest |
|
At a quick glance the ASAN test failure in dns_filter_integration_test is in libc++. FWIW, all *SAN tests should be used with appropriately instumented libc, but that will increase CI memory usage. |
|
It appears that the 1.7 branch is missing the recent CI-related fixes for tsan tests (envoyproxy#12134), which should at least resolve tsan flakes (vhds_integration_test is one). |
|
I have cherry-picked that PR into 1.7, let's see if that fixes the issues: #241 |
|
It's ASan that's failing here, so TSan fix won't fix it. |
|
that's right. I closed it. |
lizan
approved these changes
Jul 23, 2020
jwendell
force-pushed
the
release-1.7-codeowners
branch
from
f9ed575 to
bf8043f
Compare
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 19, 2021
…io#239) Fix for CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code) Signed-off-by: Greg Greenway <[email protected]> Co-authored-by: Christoph Pakulski <[email protected]> Signed-off-by: Tony Allen <[email protected]>
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
…io#239) Fix for CVE-2021-28683 (crash when peer sends an SSL Alert with an unknown code) Signed-off-by: Greg Greenway <[email protected]> Co-authored-by: Christoph Pakulski <[email protected]> Signed-off-by: Tony Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.