mixerplugin: deprecate attribute_for_mixer_proxy #10459
Conversation
| @@ -344,9 +347,6 @@ var ( | |||
| Node: &model.Proxy{ | |||
| ID: "pod2.ns2", | |||
| Type: model.Sidecar, | |||
| Metadata: map[string]string{ | |||
There was a problem hiding this comment.
why is this metadata removed and not replaced with NODE_UID and NODE_NAMESPACE ?
There was a problem hiding this comment.
This is mock metadata to satisfy the plugin interface. It has nothing to do with actual envoy metadata. There is an issue here, that the test combines inbound and outbound routes into one proxy, which is no longer possible with one UID per all configs, but that's for later.
Signed-off-by: Kuat Yessenov <[email protected]>
Signed-off-by: Kuat Yessenov <[email protected]>
kyessenov
force-pushed
the
attribute_for_mixer_proxy
branch
from
e3a627a to
c164a43
Compare
|
Ping @mandarjog . |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyessenov, mandarjog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It turns out that attributes_for_mixer_proxy has been de-facto broken since around istio/proxy#1961
This PR removes it since it doesn't work, and replaces with NODE_UID and NODE_NAMESPACE per new style.
It also adds an integration test exercising the code path in envoy.
/cc @mandarjog
/cc @douglas-reid
Signed-off-by: Kuat Yessenov [email protected]