test: Wrap proto string in std::string before comparison (#4238)

Risk Level: Low Testing: Unit Docs Changes: N/A Release Notes: N/A Signed-off-by: James Synge <[email protected]>
istio · Aug 27, 2018 · 52beb06 · 52beb06
1 parent f5e219e
commit 52beb06
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/test/integration/hds_integration_test.cc b/test/integration/hds_integration_test.cc
@@ -179,8 +179,9 @@ class HdsIntegrationTest : public HttpIntegrationTest,
     if (address->ip()->port() != endpoint.endpoint().address().socket_address().port_value()) {
       return false;
     }
+    // SocketAddress.address is a proto string, not std::string, so convert it before comparing.
     if (address->ip()->addressAsString() !=
-        endpoint.endpoint().address().socket_address().address()) {
+        absl::string_view(endpoint.endpoint().address().socket_address().address())) {
       return false;
     }
     return true;