Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update envoy #1838

Merged
merged 1 commit into from
Jul 3, 2018
Merged

update envoy #1838

merged 1 commit into from
Jul 3, 2018

Conversation

kyessenov
Copy link
Contributor

Signed-off-by: Kuat Yessenov [email protected]

What this PR does / why we need it: Update envoy to pick up PR envoyproxy/envoy#3778

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): ensure backwards-compatibility of filter configs

Signed-off-by: Kuat Yessenov <[email protected]>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 3, 2018
@istio-testing istio-testing requested review from lizan and rshriram July 3, 2018 19:57
@kyessenov
Copy link
Contributor Author

cc @hklai @qiwzhang

Copy link
Contributor

@qiwzhang qiwzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Please update proxy in istio/istio as well.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, kyessenov, qiwzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai hklai merged commit 5b05f36 into istio:release-1.0 Jul 3, 2018
@kyessenov kyessenov deleted the extra_field branch July 3, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants