Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add connection requested server name attribute to TCP read filter" #1844

Merged

Conversation

hklai
Copy link
Contributor

@hklai hklai commented Jul 10, 2018

Reverts #1843

Merged prematurely. @qiwzhang had not reviewed and API had not been updated.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 10, 2018
@istio-testing istio-testing requested review from linsun and rshriram July 10, 2018 20:58
Copy link
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hklai, kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lizan

Assign the PR to them by writing /assign @lizan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai hklai merged commit 1a62f8b into release-1.0 Jul 10, 2018
@rkpagadala rkpagadala deleted the revert-1843-add_connection_requested_server_name_attribute branch December 4, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants