telemetry: fix handling of off-GCP generic node cases #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/M
|
/cc @FrimIdan |
|
/test test_proxy |
douglas-reid
added
the
cherrypick/release-1.14
|
In response to a cherrypick label: new pull request created: #4004 |
douglas-reid
added
the
cherrypick/release-1.15
|
In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio/proxy#release-1.14 from head istio-testing:cherry-pick-4003-to-release-1.14: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between istio:release-1.14 and istio-testing:cherry-pick-4003-to-release-1.14"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} |
|
In response to a cherrypick label: new pull request created: #4006 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain off-GCP testing scenarios, the Stackdriver extension can be used with no platform metadata (no
GCP_METADATA). This can lead to proxy crashes when trying to lookup platform metadata when building a Monitored Resource for reporting.This PR adds a check to ensure platform metadata exists when building
generic_nodeMRs. A test is added to ensure no crashing.Fixes istio/istio#40201