Update deps #4276
Merged
Update deps #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-delgado
added
the
release-notes-none
istio-testing
added
the
size/L
|
/retest |
|
/test test |
lei-tang
approved these changes
Dec 12, 2022
|
Needs a PR to handle deprecation. |
|
@jacob-delgado I added a DNM label so the PR will not be merged automatically before the reviewers' comments are addressed. |
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
jacob-delgado
commented
Dec 14, 2022
| @@ -3,27 +3,30 @@ module istio.io/proxy | |||
| go 1.19 | |||
|
|
|||
| require ( | |||
| github.com/cncf/udpa/go v0.0.0-20210930031921-04548b0d99d4 | |||
There was a problem hiding this comment.
go get said to use github.com/cncf/xds/go instead
Can I get another review? |
zirain
approved these changes
Dec 14, 2022
@kyessenov Hi Kuat, has your comment been addressed? If yes, please feel free to remove the DNM label. |
kyessenov
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update various deps in go.mod and minor nits fixed to better follow go conventions. Also handle deprecations for stackdriver
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: