Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert camel_case_fields #4277

Merged
merged 1 commit into from
Dec 12, 2022
Merged

revert camel_case_fields #4277

merged 1 commit into from
Dec 12, 2022

Conversation

zirain
Copy link
Member

@zirain zirain commented Dec 11, 2022

@zirain zirain added the cherrypick/release-1.16 Set this label on a PR to auto-merge it to the release-1.16 branch label Dec 11, 2022
@zirain zirain requested a review from a team as a code owner December 11, 2022 05:10
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2022
ericvn
ericvn approved these changes Dec 11, 2022
View reviewed changes
Copy link

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyessenov
Copy link
Contributor

Thanks!

@istio-testing istio-testing merged commit 051d369 into istio:master Dec 12, 2022
@istio-testing istio-testing mentioned this pull request Dec 12, 2022
Merged
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #4279

@zirain zirain deleted the revert_camel_case branch December 13, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyessenov kyessenov kyessenov approved these changes

@ericvn ericvn ericvn approved these changes

Assignees
No one assigned
Labels
cherrypick/release-1.16 Set this label on a PR to auto-merge it to the release-1.16 branch size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zirain @kyessenov @istio-testing @ericvn