Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload-env-default #4307

Merged
merged 1 commit into from Jan 3, 2023
Merged

workload-env-default #4307

merged 1 commit into from Jan 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 30, 2022

Ability to customize the WORKLOAD_IDENTITY ENV variable
This will make using RBE easier for building proxy on a different google cloud project

@ghost ghost self-requested a review as a code owner December 30, 2022 19:13
@istio-policy-bot
Copy link

😊 Welcome @jtischer-acasi! This is either your first contribution to the Istio proxy repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2022
@jacob-delgado
Copy link
Contributor

cc @kyessenov can you take a look at this?

@ghost
Copy link
Author

ghost commented Dec 31, 2022

/test test-tsan

@ghost
Copy link
Author

ghost commented Dec 31, 2022

test-tsan_proxy is timing out after running for 4 hours; not sure why

@istio-testing istio-testing merged commit 57a91d1 into istio:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants