Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bazel to 0.22 and LLVM/clang to 7. #1167

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

PiotrSikora
Copy link
Contributor

Signed-off-by: Piotr Sikora [email protected]

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 8, 2019
@sebastienvas sebastienvas requested a review from utka February 8, 2019 19:36
@sebastienvas
Copy link
Contributor

@utka once this is merged, you would need to build the new image, and update the proxy jobs in https://github.com/istio/test-infra/blob/master/prow/cluster/jobs/istio/proxy/istio.proxy.master.yaml#L4.

The proxy jobs haven't been updated to use podutils, so we should do so, and while we do that, we should create an image for proxy, in this dir https://github.com/istio/test-infra/tree/master/docker/istio

@PiotrSikora
Copy link
Contributor Author

/assign @sebastienvas

@wenchenglu
Copy link

/lgtm
/approve

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PiotrSikora, wenchenglu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas

If they are not already assigned, you can assign the PR to them by writing /assign @sebastienvas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wenchenglu wenchenglu merged commit 407e755 into istio:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants