More consistent logging for inpod #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log UID wherever we can basically. Only other difference is to log the error before we say we are retrying, instead of after (which makes it seem like the error is after the retry)
howardjohn
added
release-notes-none
istio-testing
added
the
size/M
bleggett
approved these changes
Aug 7, 2024
|
In response to a cherrypick label: new pull request created: #1257 |
antonioberben
pushed a commit
to antonioberben/ztunnel
that referenced
this pull request
Oct 1, 2024
Log UID wherever we can basically. Only other difference is to log the error before we say we are retrying, instead of after (which makes it seem like the error is after the retry)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log UID wherever we can basically. Only other difference is to log the
error before we say we are retrying, instead of after (which makes it
seem like the error is after the retry)