auditing clone usage #418
Merged
auditing clone usage #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some clones removed - some clones were changing borrowed to owned, replaced with .to_owned() to make this clear
istio-testing
added
the
size/M
howardjohn
approved these changes
Feb 24, 2023
src/proxy/outbound.rs
Outdated
| @@ -372,7 +372,8 @@ impl OutboundConnection { | |||
| } | |||
| // For case source client and upstream server are on the same node | |||
| if !us.workload.node.is_empty() | |||
| && self.pi.cfg.local_node == Some(us.workload.node.clone()) | |||
| && !self.pi.cfg.local_node.is_none() | |||
There was a problem hiding this comment.
No. Good catch. I was planning to unwrap local_node and wanted to ensure we didn't panic but it turns out that isn't necessary. Fix coming soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some comments that may be more relevant to the reviewer than they are to future developers. If reviewer feels they've served their purpose after they read through I am happy to remove.
working on: #10