Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple dashboard to ztunnel admin #475

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Add simple dashboard to ztunnel admin #475

merged 3 commits into from
Mar 28, 2023

Conversation

hanxiaop
Copy link
Member

For convenience. Used Envoy's style.
image

@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2023
howardjohn
howardjohn reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't most of these requiring POST anyways? I am not sure how much value this adds

@hanxiaop
Copy link
Member Author

hanxiaop commented Mar 21, 2023 •
edited
Loading

Aren't most of these requiring POST anyways? I am not sure how much value this adds

I want to add this because when I try to use commands like istioctl dashboard envoy or maybe a new command for ztunnel, it shows an empty page. Most of the time, I'm only interested in seeing the config dump, and I'm not sure if we need to display other APIs. Right now it's convenient to see the configdump, and maybe we can enhance APIs like logging to do POST request like envoy.

@linsun
Copy link
Member

linsun commented Mar 28, 2023

This could be useful for dev and debugging imho

@istio-testing istio-testing merged commit b32cc7a into istio:master Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanxiaop @linsun @howardjohn @istio-testing